Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to Go 1.13. Closes #1375 #2097

Merged
merged 41 commits into from
Feb 12, 2020
Merged

feat: upgrade to Go 1.13. Closes #1375 #2097

merged 41 commits into from
Feb 12, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 29, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Closes #1375

@alexec alexec changed the title feat: upgrade to Go 13 feat: upgrade to Go 1.13. Closes #1375 Jan 29, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020 •
edited
Loading

Codecov Report

Merging #2097 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2097   +/-   ##
======================================
  Coverage    11.7%   11.7%           
======================================
  Files          52      52           
  Lines       26313   26313           
======================================
  Hits         3081    3081           
  Misses      22837   22837           
  Partials      395     395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e967e9a...527afa1. Read the comment docs.

@alexec alexec added this to the v2.6 milestone Jan 30, 2020
@alexec alexec mentioned this pull request Jan 30, 2020
Closed
@alexec alexec marked this pull request as ready for review January 30, 2020 02:22
@simster7 simster7 mentioned this pull request Jan 30, 2020
Closed
5 tasks
alexmt
alexmt reviewed Feb 7, 2020
View reviewed changes
hack/generate-proto.sh
done

# collect_swagger gathers swagger files into a subdirectory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argo don't need swagger scheme any more ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need anther PR for this

alexmt
alexmt approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add one comment about go modules caching.

I've noticed that codegen and swagger were removed. LGTM as long it is intentional and you have a plan to restore/replace it with something else.

@alexec alexec merged commit 2672857 into argoproj:master Feb 12, 2020
@alexec alexec deleted the go13 branch February 12, 2020 00:01
@tonyyang-svail tonyyang-svail mentioned this pull request Feb 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@simster7 simster7 simster7 left review comments

@alexmt alexmt alexmt approved these changes

Assignees

@alexmt alexmt

Labels
None yet
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

Add support for Go modules, upgrade to Go 1.13
4 participants
@alexec @alexmt @simster7 @golangcibot